Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/deepmap/oapi-codegen from 1.12.4 to 1.16.2 in /backend #745

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 18, 2024

Bumps github.com/deepmap/oapi-codegen from 1.12.4 to 1.16.2.

Release notes

Sourced from github.com/deepmap/oapi-codegen's releases.

v1.16.2: Further improve documentation notices

What's Changed

Full Changelog: oapi-codegen/oapi-codegen@v1.16.1...v1.16.2

v1.16.1: Ensure deprecation comments appear correctly

What's Changed

Full Changelog: oapi-codegen/oapi-codegen@v1.16.0...v1.16.1

v1.16.0: Reduce runtime dependencies

As part of the final preparation towards the v2 release, this release finalises the use of the new multi-repo packages, and deprecates all internal packages ahead of next week's release removing them.

Key callouts

Full Changelog: oapi-codegen/oapi-codegen@v1.15.0...v1.16.0

v1.13.4

What's Changed

Full Changelog: oapi-codegen/oapi-codegen@v1.13.3...v1.13.4

v1.13.3

What's Changed

Full Changelog: oapi-codegen/oapi-codegen@v1.13.2...v1.13.3

Fix: Allow multiple JSON types to be generated

What's Changed

Full Changelog: oapi-codegen/oapi-codegen@v1.13.1...v1.13.2

v1.13.1: Various fixes post-release

What's Changed

... (truncated)

Commits
  • 5d2cd60 Add missing types to deprecation URLs
  • 81b4e34 Add pkg.go.dev links to deprecation warnings
  • eb5e119 Fix: Ensure deprecations are parsed correctly
  • d663b6c Add deprecation notice for testutil
  • 6d98312 Migrate to separate testutil package
  • 82cbf4a Replace Echo-specific handler call
  • 46d2694 Onboard to Renovate
  • 58e3d16 Deprecate existing middleware
  • 2d349f4 Migrate middleware to their own Go modules
  • af55078 Bump Iris to remove Go 1.21 dependency
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Mar 18, 2024
@dependabot dependabot bot force-pushed the dependabot/go_modules/backend/github.com/deepmap/oapi-codegen-1.16.2 branch 4 times, most recently from ab294cb to 4d6512e Compare March 21, 2024 11:40
Bumps [github.com/deepmap/oapi-codegen](https://github.com/deepmap/oapi-codegen) from 1.12.4 to 1.16.2.
- [Release notes](https://github.com/deepmap/oapi-codegen/releases)
- [Commits](oapi-codegen/oapi-codegen@v1.12.4...v1.16.2)

---
updated-dependencies:
- dependency-name: github.com/deepmap/oapi-codegen
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/backend/github.com/deepmap/oapi-codegen-1.16.2 branch from 4d6512e to 1048d8a Compare March 21, 2024 11:41
@dongsupark
Copy link
Member

CI fails:

./tools/golangci-lint run --fix
level=warning msg="[runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner. Replaced by revive."
Error: pkg/server/server.go:108:8: SA1019: oapimiddleware.OapiRequestValidatorWithOptions is deprecated: This has been replaced by https://pkg.go.dev/github.com/oapi-codegen/echo-middleware#OapiRequestValidatorWithOptions (staticcheck)
	e.Use(oapimiddleware.OapiRequestValidatorWithOptions(swagger, &oapimiddleware.Options{Options: openapi3filter.Options{AuthenticationFunc: nebraskaAuthenticationFunc(conf.AuthMode)}, Skipper: middlewareSkipper}))
	      ^
make: *** [Makefile:101: code-checks] Error 1

Replace github.com/deepmap/oapi-codegen/pkg/middleware with
github.com/oapi-codegen/echo-middleware in pkg/server/server.go,
to fix golangci-lint errors with oapi-codegen 1.16+ like:

```
./tools/golangci-lint run --fix
Error: pkg/server/server.go:108:8: SA1019: oapimiddleware.OapiRequestValidatorWithOptions
is deprecated: This has been replaced by
https://pkg.go.dev/github.com/oapi-codegen/echo-middleware#OapiRequestValidatorWithOptions
(staticcheck)
    e.Use(oapimiddleware.OapiRequestValidatorWithOptions(swagger,
    &oapimiddleware.Options{Options:
    openapi3filter.Options{AuthenticationFunc: nebraskaAuthenticationFunc(conf.AuthMode)},
    Skipper: middlewareSkipper}))
```
@dongsupark
Copy link
Member

Fixed the golangci-lint failure.

However, apart from that specific failure, I think it looks necessary to update oapi-codegen versions in other parts like Makefile.
I am not sure I feel confident with touching the oapi-codegen part.

@dongsupark
Copy link
Member

Closing due to too many merge conflicts

@dongsupark dongsupark closed this Mar 27, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 27, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dongsupark dongsupark deleted the dependabot/go_modules/backend/github.com/deepmap/oapi-codegen-1.16.2 branch March 27, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant