-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys-kernel/bootengine: fix systemd-vconsole-setup for systemd 255 #1684
Conversation
Firstly, let's run the CI to get the size of the kernel / initrd / image without any changes. To be logged here. |
Build action triggered: https://github.com/flatcar/scripts/actions/runs/8067206982 |
Use PR flatcar/bootengine#87 Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
Thanks for the numbers, 1MB is quite a lot for the initrd - we reduced the initrd size with many tricks already and I think we need one more here by only inserting the required binary instead of the whole internationalization module. |
I looked on the systemd / dracut issues related to this topic, and the amount of discussion / code change is quite high -> systemd/systemd#6689, systemd/systemd#15479, systemd/systemd@e019ea7, systemd/systemd@a6f3a7e, dracutdevs/dracut#797. If we go with a non-standard way, we will probably open the gates for random bugs / behaviour during the initrd stage. Testing under way for the non-standard implementation: ader1990/bootengine@a92ce96 |
I tried with the stripped down version of the i18n dracut module, using this HEAD ader1990/bootengine@9f37ee5. The loadkeys binary was succesfully installed in the initrd, but the execution of the binary failed with At this moment, I can only suggest to use the upstream version of the dracut module, the one that is properly tested to work with systemd. |
Closing PR, systemd 255 will use the i18n dracut module directly. |
Use #1679 for fixing the upcoming systemd 255 upgrade.
Required-by: #1679
changelog/
directory (user-facing change, bug fix, security fix, update)/boot
and/usr
size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.