Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog: upgrade toolbox to latest version #1785

Conversation

daMupfel
Copy link
Contributor

@daMupfel daMupfel commented Mar 22, 2024

This version fixes that mounted snapshots with ctr are being gc'ed which breaks the toolbox.

Upgrade toolbox

As requested on toolbox pr flatcar/toolbox#9.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@daMupfel daMupfel force-pushed the dont-remove-snapshot-on-gc-after-lease-expiration branch 2 times, most recently from 2e2655d to 2030e78 Compare March 22, 2024 14:55
Copy link
Member

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I made a minor suggestion for the release note wording

@daMupfel daMupfel force-pushed the dont-remove-snapshot-on-gc-after-lease-expiration branch 2 times, most recently from 4772a5e to 9dbdfb3 Compare March 26, 2024 07:22
@daMupfel
Copy link
Contributor Author

Hi pothos,

Thanks for the review. I adapted according to your request :).

Regards,

David

This version fixes that mounted snapshots with ctr are being gc'ed which
breaks the toolbox.
@daMupfel daMupfel force-pushed the dont-remove-snapshot-on-gc-after-lease-expiration branch from 9dbdfb3 to e5179b2 Compare March 26, 2024 07:26
@pothos pothos merged commit e5930f7 into flatcar:main Mar 26, 2024
pothos added a commit that referenced this pull request Mar 26, 2024
changelog: upgrade toolbox to latest version
pothos added a commit that referenced this pull request Mar 26, 2024
changelog: upgrade toolbox to latest version
pothos added a commit that referenced this pull request Mar 26, 2024
changelog: upgrade toolbox to latest version
pothos added a commit that referenced this pull request Mar 26, 2024
changelog: upgrade toolbox to latest version
@pothos
Copy link
Member

pothos commented Mar 26, 2024

Thanks, I've backported it to all channels

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants