Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONFIG_PPS_CLIENT_GPIO=m #1948

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Add CONFIG_PPS_CLIENT_GPIO=m #1948

merged 3 commits into from
Apr 24, 2024

Conversation

space55
Copy link
Contributor

@space55 space55 commented Apr 22, 2024

Closes 1430

Add CONFIG_PPS_CLIENT_GPIO=m

This will enable the PPS GPIO kernel module to be used in arm64 builds. It can be done in the common config as well, however, I personally would anticipate that arm64 instances are much more likely to have a use for PPS GPIO than x86, and as such, shouldn't be needed in the common config. Please let me know if it would be desirable to have this setting elsewhere.

How to use

System without this change

$ modprobe pps-gpio
modprobe: FATAL: Module pps-gpio not found in directory /lib/modules/6.1.85-flatcar

System with this change

$ modprobe pps-gpio
$ # Note: no output

Alternatively:

$ lsmod | grep gpio
pps_gpio               16384  1

Testing done

Currently need an image of Flatcar to be built by CI for me to test

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

Closes flatcar/Flatcar:1430
@pothos
Copy link
Member

pothos commented Apr 23, 2024

The image is available in the arm64-generic-image.zip https://github.com/flatcar/scripts/actions/runs/8792407190?pr=1948
If you already have an install on an arm64 board, you can also extract the update payload from arm64-test-update.zip and switch to it with flatcar-update with -D -V 1.2.3 -P FILE (after testing, go back to a proper channel with flatcar-update -F … so that you receive updates again).

Copy link

@space55
Copy link
Contributor Author

space55 commented Apr 23, 2024

Confirmed that the image does, in fact, still boot, and the pps-gpio module is loaded when the modprobe pps-gpio command is executed.

@pothos pothos merged commit 5f177df into flatcar:main Apr 24, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Enable CONFIG_PPS_CLIENT_GPIO in kernel
3 participants