app-emulation/wa-linux-agent: Use networkctl to propagate hostname #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9556c7f because waagent looks for internal hostname changes and wants to propagate them to the Azure VM properties by issuing a new DHCP request.
The if-up-down to trigger the DHCP request causes problems. It's better to directly ask systemd-networkd to issue the request. It seems that one needs to use "reconfigure" instead of "forcerenew", so I went with only that instead of somehow trying to see if "forcerenew" has an effect.
jepio
added a commit
that referenced
this pull request
Jun 21, 2024
app-emulation/wa-linux-agent: Use networkctl to propagate hostname Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The if-up-down to trigger the DHCP request causes problems. It's better
to directly ask systemd-networkd to issue the request. It seems that
one needs to use "reconfigure" instead of "forcerenew", so I went with
only that instead of somehow trying to see if "forcerenew" has an
effect.
How to use
For this comment #1950 (comment)
Testing done
Used
flatcar-update -P … -E …to switch to the built image, and checked that waagent triggers the DHCP renewal:There is no
Link DOWN,Lost carrieranymore foreth0andenP52305s1.