Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenStack: Changed metadata hostname source order #2010

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

alejandro-ripoll
Copy link

OpenStack: Changed metadata hostname source order

Change flatcar-openstack-hostname.service to use afterburn openstack provider implemented on coreos/afterburn#462 instead of openstack-metadata.

Closes: flatcar/Flatcar#1445

BootEngine PR: flatcar/bootengine#96
Superseeds #2009

How to use

[ describe what reviewers need to do in order to validate this PR ]

Testing done

[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@ader1990
Copy link
Contributor

Hello @alejandro-ripoll,

You need to readd to the commit the correct CROSS WORKON ID for the bootengine: flatcar/bootengine@fb2631c.

Also, the changelog entry needs to reflect the correct PR ID and the commit message needs to be smaller and in the commit description to add the necessary links / what has been changed.

Thank you.

Copy link

github-actions bot commented May 30, 2024

Change `flatcar-openstack-hostname.service` to use afterburn `openstack` provider implemented on coreos/afterburn#462  instead of `openstack-metadata`.
BootEngine PR: flatcar/bootengine#96
@alejandro-ripoll
Copy link
Author

Hello @alejandro-ripoll,

You need to readd to the commit the correct CROSS WORKON ID for the bootengine: flatcar/bootengine@fb2631c.

Also, the changelog entry needs to reflect the correct PR ID and the commit message needs to be smaller and in the commit description to add the necessary links / what has been changed.

Thank you.

Thanks @ader1990 and @tormath1. I think it should be alright now.

Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect. Thanks for your first contribution!

@tormath1 tormath1 merged commit a91715a into flatcar:main Jun 7, 2024
1 check failed
@tormath1
Copy link
Contributor

tormath1 commented Jun 7, 2024

picked to:

  • flatcar-3975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants