Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-nvme-utils: Migrate coreos-overlay to portage-stable, 0.2.0 bump #2252

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

chewi
Copy link
Contributor

@chewi chewi commented Aug 26, 2024

azure-nvme-utils: Migrate to portage-stable, 0.2.0 bump

The coreos-overlay package under app-admin was written by Jeremi around the same time I added it to Gentoo under sys-apps. It has had a new release since.

How to use

Build the package?

Testing done

A Jenkins packages_all_arches job was run against Azure. All passed and no notable changes.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

The coreos-overlay package under app-admin was written by Jeremi around
the same time I added it to Gentoo under sys-apps. It has had a new
release since.

Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
@chewi chewi requested a review from a team August 26, 2024 09:23
@chewi chewi self-assigned this Aug 26, 2024
Co-authored-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
@chewi
Copy link
Contributor Author

chewi commented Aug 26, 2024

Now properly testing on Azure using Kola, as requested.

core@kola-9129ebae-969a5c49bd ~ $ ls -l /dev/disk/azure/
total 0
drwxr-xr-x. 4 root root 80 Aug 26 13:02 local
lrwxrwxrwx. 1 root root 13 Aug 26 13:02 os -> ../../nvme0n1
lrwxrwxrwx. 1 root root 15 Aug 26 13:02 os-part1 -> ../../nvme0n1p1
lrwxrwxrwx. 1 root root 15 Aug 26 13:02 os-part2 -> ../../nvme0n1p2
lrwxrwxrwx. 1 root root 15 Aug 26 13:02 os-part3 -> ../../nvme0n1p3
lrwxrwxrwx. 1 root root 15 Aug 26 13:02 os-part4 -> ../../nvme0n1p4
lrwxrwxrwx. 1 root root 15 Aug 26 13:02 os-part6 -> ../../nvme0n1p6
lrwxrwxrwx. 1 root root 15 Aug 26 13:02 os-part7 -> ../../nvme0n1p7
lrwxrwxrwx. 1 root root 15 Aug 26 13:02 os-part9 -> ../../nvme0n1p9

Copy link

github-actions bot commented Aug 26, 2024

@chewi chewi requested a review from jepio August 26, 2024 14:10
@jepio
Copy link
Member

jepio commented Aug 26, 2024

Now properly testing on Azure using Kola, as requested.

core@kola-9129ebae-969a5c49bd ~ $ ls -l /dev/disk/azure/
total 0
drwxr-xr-x. 4 root root 80 Aug 26 13:02 local
lrwxrwxrwx. 1 root root 13 Aug 26 13:02 os -> ../../nvme0n1
lrwxrwxrwx. 1 root root 15 Aug 26 13:02 os-part1 -> ../../nvme0n1p1
lrwxrwxrwx. 1 root root 15 Aug 26 13:02 os-part2 -> ../../nvme0n1p2
lrwxrwxrwx. 1 root root 15 Aug 26 13:02 os-part3 -> ../../nvme0n1p3
lrwxrwxrwx. 1 root root 15 Aug 26 13:02 os-part4 -> ../../nvme0n1p4
lrwxrwxrwx. 1 root root 15 Aug 26 13:02 os-part6 -> ../../nvme0n1p6
lrwxrwxrwx. 1 root root 15 Aug 26 13:02 os-part7 -> ../../nvme0n1p7
lrwxrwxrwx. 1 root root 15 Aug 26 13:02 os-part9 -> ../../nvme0n1p9

Does the local dir also have symlinks for the other nvme drive? (it shouldn't be empty)

Copy link
Member

@jepio jepio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets just validate the other symbolic links and then: good to go

@chewi
Copy link
Contributor Author

chewi commented Aug 26, 2024

I have this in my scrollback, good enough?

core@kola-9129ebae-969a5c49bd ~ $ ls -l /dev/disk/azure/local/by-name/
total 0
lrwxrwxrwx. 1 root root 19 Aug 26 13:02 nvme-220G-1 -> ../../../../nvme1n1

@jepio
Copy link
Member

jepio commented Aug 27, 2024

Yup, thanks

@chewi chewi merged commit 35aa63d into main Aug 27, 2024
1 check failed
@chewi chewi deleted the chewi/azure-nvme-utils branch August 27, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

3 participants