net-firewall/conntrack-tools: remove obsolete 1.4.5 #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the Manifest too. I know we don't run QA tools that would check that but... |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/10595671568 |
You're right! Good catch, will update. We should make use of these QA tools one day... |
This change removes an outdated conntrack-tools ebuild - version 1.4.5 - from maintenance branch flatcar-4054. The branch uses 1.4.6-rc1 anyways so the legacy ebuild can safely be deleted. This ebuild uses EAPI 6 and will cause a transient error message during build. It imports the linux-info eclass which was recently updated to only support EAPI 7 and higher. This will cause emerge to print an error message when considering the 1.4.5 ebuild. While that error message has no impact on the build because 1.4.6-rc1 is more recent and will hence be used, it can be misleading when investigating unrelated issues (which it did to me, hence this patch). Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
t-lo
force-pushed
the
t-lo/flatcar-4054-remove-conntrack-1.4.5
branch
from
44d5c7c
to
8644d6c
Compare
chewi
approved these changes
Aug 27, 2024
|
Tests are green except for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes an outdated conntrack-tools ebuild - version 1.4.5 - from maintenance branch flatcar-4054. The branch uses 1.4.6-rc1 anyways so the legacy ebuild can safely be deleted.
This ebuild uses EAPI 6 and will cause a transient error message during build. It imports the linux-info eclass which was recently updated to only support EAPI 7 and higher. This will cause emerge to print an error message when considering the 1.4.5 ebuild. While that error message has no impact on the build because 1.4.6-rc1 is more recent and will hence be used, it can be misleading when investigating unrelated issues (which it did to me, hence this patch).
How to use
git clone https://github.com/flatcar/scripts.git cd scripts git checkout t-lo/flatcar-4054-remove-conntrack-1.4.5Testing done
Built the image (see above), built qemu uefi image, ran tests locally.