sys-block/open-iscsi: Migrate coreos-stable to portage-stable, 2.1.10 #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krnowak
reviewed
Aug 29, 2024
sdk_container/src/third_party/coreos-overlay/coreos/config/env/sys-block/open-iscsi
Show resolved
Hide resolved
chewi
force-pushed
the
chewi/open-iscsi
branch
from
1ab9a51
to
dd59853
Compare
chewi
force-pushed
the
chewi/open-iscsi
branch
from
dd59853
to
df67017
Compare
chewi
force-pushed
the
chewi/open-iscsi
branch
from
df67017
to
ee4f8c3
Compare
jepio
reviewed
Aug 30, 2024
sdk_container/src/third_party/coreos-overlay/coreos/config/env/sys-block/open-iscsi
Show resolved
Hide resolved
chewi
force-pushed
the
chewi/open-iscsi
branch
from
ee4f8c3
to
dea9fc2
Compare
The old version 2.1.4 does not cross-compile without help from QEMU that we cannot rely on going forwards. 2.1.10 is Meson-based and handles this much better. Rather than update the package in-place, migrate it to portage-stable and cover the differences with a small patch and env script. Upstream now carries the systemd files, so we do not need to add these. /etc is now automatically moved to /usr/share/flatcar/etc, so we no longer need any special handling for that here, but I have added a compatibility symlink for iscsid.conf. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
chewi
force-pushed
the
chewi/open-iscsi
branch
from
dea9fc2
to
40e1c0e
Compare
chewi
changed the title
|
Took a few goes to get it right, but it's looking good now. gen_tmpfiles.py takes care of the tmpfiles stuff now, so the env script is shorter. 2.1.10 got stabilised in the meantime. |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/10681915683 |
krnowak
approved these changes
Sep 3, 2024
sdk_container/src/third_party/coreos-overlay/coreos/config/env/sys-block/open-iscsi
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open-iscsi: Migrate to portage-stable, 2.1.10 bump
The old version 2.1.4 does not cross-compile without help from QEMU that we cannot rely on going forwards. 2.1.10 is Meson-based and handles this much better.
Rather than update the package in-place, migrate it to portage-stable and cover the differences with a small patch and env script. Upstream now carries the systemd files, so we do not need to add these.
How to use
sudo systemctl start iscsid/etc/iscsi/initiatorname.iscsi.targetclion the host.sudo iscsiadm -m discovery -t sendtargets -p <host LAN IP>sudo iscsiadm -m node -l -T <target from above> -p <host LAN IP>sudo systemctl enable iscsiTesting done
I did the above. I also ran a Jenkins job against qemu_uefi. It was suggested that I add a Kola test. The usual way to write a test like this would be to spin up two instances as the client and server. I'd like to do this, but
targetcli, which manages the Linux server, is written in Python, which Flatcar doesn't have.changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.