Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eclass/coreos-kernel: add -Werror=misleading-indentation #2288

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

tormath1
Copy link
Contributor

@tormath1 tormath1 commented Sep 5, 2024

To ensure that tested patches are correctly indented.


In this PR, we set a C flags for Kernel build to ensure that the indentation is correctly respected when building Kernel - it's helpful when testing patches before submission to avoid this kind of issue: https://lore.kernel.org/stable/2024090532-earthworm-sincere-005e@gregkh/

Testing done

No changelog as it's not user facing.

To ensure that tested patches are correctly indented.

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1 tormath1 self-assigned this Sep 5, 2024
@tormath1 tormath1 marked this pull request as ready for review September 5, 2024 17:19
@tormath1 tormath1 requested a review from a team September 5, 2024 17:19
Copy link
Contributor

@ader1990 ader1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tormath1 tormath1 merged commit abeddbd into main Sep 6, 2024
1 check failed
@tormath1 tormath1 deleted the tormath1/kernel-indentation branch September 6, 2024 08:28
@tormath1
Copy link
Contributor Author

tormath1 commented Sep 6, 2024

cherry-picked to:

  • flatcar-4081
  • flatcar-4054
  • flatcar-3975
  • flatcar-3510

Copy link

github-actions bot commented Sep 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants