Publish stage 3 SDK tarball to use as a seed instead of stage 4 #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently use a stage 4 tarball as a seed for building the SDK, but stage 3 is smaller and less likely to cause issues. This doesn't change the name of the tarball because supporting both stage3 and stage4 at the same time just isn't feasible with the way the digest check works. The change is almost backwards compatible except that Catalyst will fail to build older baselayout versions due to stage3 lacking git. A recent change to the baselayout package sources it from a tarball instead of git, and this has now made it into a release. This issue only affects building the SDK, and it can be resolved by simply rebasing. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
chewi
changed the title
|
The sdk tarball is also used for building SDK docker images. Did you test if the stage3 is usable here too? See |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/10777130616 |
|
Ah damn, I think that torpedoes the whole thing. I was previously told it was only used for the seed. If it used the "stage4" file directly while that was still around, that would be okay, but it looks like it can at least potentially fetch it from the bincache, so we'd have to publish both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish stage 3 SDK tarball to use as a seed instead of stage 4
We currently use a stage 4 tarball as a seed for building the SDK, but stage 3 is smaller and less likely to cause issues.
This doesn't change the name of the tarball because supporting both stage3 and stage4 at the same time just isn't feasible with the way the digest check works.
The change is almost backwards compatible except that Catalyst will fail to build older baselayout versions due to stage3 lacking git. A recent change to the baselayout package sources it from a tarball instead of git, and this has now made it into a release. This issue only affects building the SDK, and it can be resolved by simply rebasing.
How to use
You can't really try this change specifically, but you can build the SDK up to stage 3 and then manually use that tarball as a seed to build another SDK.
Testing done
I have tested this manually as much as I can, but the change itself cannot be tested in the usual way because it involves publishing the tarball. The change is at least relatively small.
changelog/directory (user-facing change, bug fix, security fix, update) -- N/A/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc. -- N/A