Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate updates of system packages: sys-apps/* #822

Merged
merged 28 commits into from
Jun 15, 2023

Conversation

sayanchowdhury
Copy link
Member

@sayanchowdhury sayanchowdhury commented May 16, 2023

Automate updates of system packages: sys-apps/*

TODO for sayan

  • Drop the sys-apps/acl as it's already updated.
  • Fix the names for coreutils and debianutils
  • groff is not updated, fix the commit message

--

--

Testing done

CI Running http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/807/cldsv/
CI Running http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/821/cldsv/

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@sayanchowdhury sayanchowdhury force-pushed the sayan/weekly-update-04052023 branch 4 times, most recently from 45ae5c3 to 48aad23 Compare May 18, 2023 07:15
@sayanchowdhury sayanchowdhury changed the title (wip) Automate updates of system packages: sys-apps/* Automate updates of system packages: sys-apps/* May 18, 2023
@sayanchowdhury sayanchowdhury marked this pull request as ready for review May 18, 2023 07:22
@krnowak
Copy link
Member

krnowak commented May 22, 2023

  • sys-apps/kmod (PROD) (DEV)

    • from 29 to 39

to 30. But you got it right in the changelog.

  • sys-apps/man-pages (PROD) (DEV)

Is this really in production images? I think it's only dev container.

  • sys-apps/nvme-cli (PROD) (DEV)

    • from 1.16 to 2.3

This needs some keywords stuff for amd64, because it has version 2.2.1, not 2.3. arm64 has 2.3 (from what I've seen in the build logs).

I couldn't find the package listings for your CI build on bincache, so I can't verify if the versions listed here are actually what's built.

@sayanchowdhury
Copy link
Member Author

  • sys-apps/kmod (PROD) (DEV)

    • from 29 to 39

Oops! yes. My finger fell a key short :)

to 30. But you got it right in the changelog.

  • sys-apps/man-pages (PROD) (DEV)

Is this really in production images? I think it's only dev container.

  • sys-apps/nvme-cli (PROD) (DEV)

    • from 1.16 to 2.3

This needs some keywords stuff for amd64, because it has version 2.2.1, not 2.3. arm64 has 2.3 (from what I've seen in the build logs).

I couldn't find the package listings for your CI build on bincache, so I can't verify if the versions listed here are actually what's built.

I'll look into both the items tomorrow.

@sayanchowdhury sayanchowdhury self-assigned this May 23, 2023
@sayanchowdhury sayanchowdhury force-pushed the sayan/weekly-update-04052023 branch 2 times, most recently from fa20560 to 3be509c Compare May 25, 2023 06:21
@sayanchowdhury
Copy link
Member Author

I've started another build with the changes: http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/821/cldsv/

@krnowak
Copy link
Member

krnowak commented May 25, 2023

sys-apps/man-pages stopped pulling in sys-apps/man-pages-posix. We should either drop the package or pull it in through the coreos-devel/sdk-depends package.

@@ -0,0 +1,17 @@
- coreutils ([9.1](https://git.savannah.gnu.org/cgit/coreutils.git/tree/NEWS?h=v9.1))
- debianutils ([5.7](https://metadata.ftp-master.debian.org/changelogs//main/d/debianutils/debianutils_5.7-0.4_changelog))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd drop it, it's not a part of developer container nor production image, and probably not that important part of SDK anyway.

@krnowak
Copy link
Member

krnowak commented May 25, 2023

I don't know why nvme-cli started installing udev and systemd stuff in parent directories (and I don't know if that's a problem):

+/usr/lib/udev/70-nvmf-autoconnect.rules
+/usr/lib/udev/71-nvmf-iopolicy-netapp.rules
-/usr/lib/udev/rules.d/70-nvmf-autoconnect.rules
-/usr/lib/udev/rules.d/71-nvmf-iopolicy-netapp.rules
+/usr/lib/systemd/nvmefc-boot-connections.service
+/usr/lib/systemd/nvmf-autoconnect.service
+/usr/lib/systemd/nvmf-connect.target
+/usr/lib/systemd/nvmf-connect@.service
-/usr/lib/systemd/system/nvmefc-boot-connections.service
-/usr/lib/systemd/system/nvmf-autoconnect.service
-/usr/lib/systemd/system/nvmf-connect.target
-/usr/lib/systemd/system/nvmf-connect@.service

@krnowak
Copy link
Member

krnowak commented May 25, 2023

I don't know why nvme-cli started installing udev and systemd stuff in parent directories (and I don't know if that's a problem):

+/usr/lib/udev/70-nvmf-autoconnect.rules
+/usr/lib/udev/71-nvmf-iopolicy-netapp.rules
-/usr/lib/udev/rules.d/70-nvmf-autoconnect.rules
-/usr/lib/udev/rules.d/71-nvmf-iopolicy-netapp.rules
+/usr/lib/systemd/nvmefc-boot-connections.service
+/usr/lib/systemd/nvmf-autoconnect.service
+/usr/lib/systemd/nvmf-connect.target
+/usr/lib/systemd/nvmf-connect@.service
-/usr/lib/systemd/system/nvmefc-boot-connections.service
-/usr/lib/systemd/system/nvmf-autoconnect.service
-/usr/lib/systemd/system/nvmf-connect.target
-/usr/lib/systemd/system/nvmf-connect@.service

I'm going to file a PR in gentoo to fix these.

@krnowak
Copy link
Member

krnowak commented May 25, 2023

Filed a PR in Gentoo - gentoo/gentoo#31159. I suppose we could wait with updating sys-apps/nvme-cli until this is fixed, or we can move it to overlay and modify it.

@krnowak
Copy link
Member

krnowak commented May 25, 2023

Needs a rebase.

@krnowak
Copy link
Member

krnowak commented May 26, 2023

Gentoo PR is merged, so maybe you could sync sys-apps/nvme-cli and sys-libs/libnvme again with gentoo and add keywords to pick up nvme-cli-2.4-r2.ebuild and libnvme-1.4 for both amd64 and arm64? This should fix the installation location of the files.

@sayanchowdhury
Copy link
Member Author

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
It's from Gentoo commit c16d7a45c02559cef8e47b04212fe11598bb0f95.
It's from Gentoo commit 0fbcc5562333ac89fc88bc5ceb72a221f6583d08.
It's from Gentoo commit 99dc89c1d75aafe8a20ef7372b901b569b874688.
It's from Gentoo commit 56bfac8875fd02185e30cdb8735fe9c81157a64d.
It's from Gentoo commit e8bcb9f7805a396c022a73865bef1086d275d8a7.
It's from Gentoo commit 4c8d6fbf8598929497d56cd1547a2c380b8355b1.
It's from Gentoo commit 40f2107268c8ec1526722cf0b0c827b09773f0ef.
It's from Gentoo commit 934965b58016e79fa4d6646bae7f56066a8d700c.
It's from Gentoo commit e6ea91a290528b5757a1060ced8c585303115596.
It's from Gentoo commit 1f6e00fbb2e1491e868b5b10472023fe8854a75b.
It's from Gentoo commit 8481d153f9f11bcf67138a5a5fce4cdb968f846f.
It's from Gentoo commit cba985622c089f355a42d163111c7021841ad3d5.
It's from Gentoo commit 6b5e8085a524f484a1262b2d4181656a56f40f7d.
It's from Gentoo commit 71be6522efb9ee61f69419b086555c2e4a4537d5.
It's from Gentoo commit a56f5788f4b3dbfece3e3765550ead2c3204b9e1.
It's from Gentoo commit 6c845d2e615aa66e92c9701cdf65ae18ce7bc526.
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
@sayanchowdhury sayanchowdhury merged commit 87d6a33 into main Jun 15, 2023
1 check failed
@sayanchowdhury sayanchowdhury deleted the sayan/weekly-update-04052023 branch June 15, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants