Detect multipart mime and ignore it #823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-samfira
force-pushed
the
detect-multipart-mime
branch
from
8d750a3
to
69027d1
Compare
This was referenced May 17, 2023
pothos
reviewed
May 19, 2023
...third_party/coreos-overlay/sys-apps/ignition/files/0019-Detect-multipart-mime-userdata.patch
Outdated
Show resolved
Hide resolved
pothos
reviewed
May 19, 2023
...third_party/coreos-overlay/sys-apps/ignition/files/0019-Detect-multipart-mime-userdata.patch
Outdated
Show resolved
Hide resolved
gabriel-samfira
force-pushed
the
detect-multipart-mime
branch
2 times, most recently
from
3354f02
to
a89ab8a
Compare
gabriel-samfira
commented
May 19, 2023
..._party/coreos-overlay/sys-apps/ignition/files/0019-detect-multipart-mime-and-ignore-it.patch
Outdated
Show resolved
Hide resolved
gabriel-samfira
force-pushed
the
detect-multipart-mime
branch
2 times, most recently
from
2b6b7b2
to
98034e4
Compare
|
/build-image |
1 similar comment
|
/build-image |
|
/build-image |
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
gabriel-samfira
force-pushed
the
detect-multipart-mime
branch
from
98034e4
to
1ea4811
Compare
|
/build-image |
|
Last time I checked |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect multipart mime user-data
This change makes ignition ignore user-data that is multipart mime.
How to use
Deploy a VM and add multipart mime userdata. If the VM boots, it works.
Testing done
Deployed a VM on OpenStack and set its userdata to a multipart mime userdata. The VM succeeded to boot.
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.