dev-lang/go: update Go to 1.20.4 #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/update-sdk |
sayanchowdhury
approved these changes
May 25, 2023
|
Just a moment. I am rerunning the CI on Jenkins http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/822/cldsv/ just in case. |
dongsupark
force-pushed
the
dongsu/go-1.20
branch
from
c46622e
to
7b2bc52
Compare
dongsupark
force-pushed
the
dongsu/go-1.20
branch
from
66efd0f
to
4769301
Compare
Add Go 1.20.4 and drop unnecessary versions 1.18.10, 1.12.17.
Update the default Go version from 1.19 to the latest 1.20. Note, we still keep setting COREOS_GO_VERSION="go1.19" for containerd, cri-tools, docker, docker-cli, docker-proxy, docker-runc, following the default version of upstream projects.
Since Go 1.20 stopped shipping pre-compiled package archives for the
standard library in $GOROOT/pkg, it became impossible to install
pkg/linux_{amd64,arm64} for every version. To avoid build failure,
install the library if the Go slot number is 1.19 or older.
Also depend on go-bootstrap 1.17.13 or newer.
See also https://go.dev/doc/go1.20.
Go 1.18 is already EOL, so no security update at all. Since upstream docker projects already have Go 1.19, Flatcar should also have that. See also https://github.com/moby/moby/blob/5d6db842238e3c4f5f9fb9ad70ea46b35227d084/Dockerfile#L6.
Add Go 1.20 to the SDK, delete the unnecessary 1.18. Delete 1.12 which does not work with go-bootstrap 1.18.
Update dev-lang/go-bootstrap to 1.18.6, by syncing with Gentoo commit 1b3154a4473deedaf3d1deb978f9a19739ac03af. This is necessary because Go >= 1.20 requires go-bootstrap to be at least 1.17.13. Drop unnecessary Flatcar patches from go-bootstrap, and move the ebuild from coreos-overlay to portage-stable.
Use Go 1.19 as Go 1.12 does not exist. Update amazon-ssm-agent to 3.2.985.0, because 2.3.1319.0 does not work with Go 1.19. Clean up unnecessary patches.
dongsupark
force-pushed
the
dongsu/go-1.20
branch
from
4769301
to
53355e2
Compare
sayanchowdhury
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
dev-lang/go1.20.4 and drop the unnecessary 1.18.10.Update the default Go version from 1.19 to the latest 1.20.
Since Go 1.20 stopped shipping pre-compiled package archives for the standard library in
$GOROOT/pkg, it became impossible to installpkg/linux_{amd64,arm64}for every version. To avoid build failure, install the library if the Go slot number is 1.19 or older.Update
dev-lang/go-bootstrapto 1.18.6, by syncing with Gentoo commit 1b3154a4473d. This is necessary because Go >= 1.20 requires go-bootstrap to be at least 1.17.13.go-bootstrap, and move the ebuild from coreos-overlay to portage-stable.COREOS_GO_VERSION="go1.19"forcontainerd,cri-tools,docker,docker-cli,docker-proxy,docker-runc, following the default version of upstream projects.amazon-ssm-agent, use Go 1.19 as Go 1.12 does not exist. Updateamazon-ssm-agentto 3.2.985.0, because 2.3.1319.0 does not work with Go 1.19.Fixes flatcar/Flatcar#1035.
Testing done
CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/825/cldsv/
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.