Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreos-base/oem-ec2-compat: fix JSON formatting #936

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

tormath1
Copy link
Contributor

@tormath1 tormath1 commented Jun 20, 2023

It was causing an issue on AWS for both arch:

$ aws ec2 get-console-output
[    8.130342] ignition[1051]: Ignition 2.15.0
[    8.131688] ignition[1051]: Stage: fetch-offline
[    8.134886] ignition[1051]: reading system config file "/usr/lib/ignition/base.d/base.ign"
[    8.137355] ignition[1051]: error at line 16 col 6: invalid character ']' looking for beginning of value
[    8.139947] ignition[1051]: failed to acquire system base config: config is not valid
[    8.142090] ignition[1051]: Ignition failed: config is not valid
[    8.145266] systemd[1]: ignition-fetch-offline.service: Main process exited, code=exited, status=1/FAILURE
[    8.147987] systemd[1]: ignition-fetch-offline.service: Failed with result 'exit-code'.
[    8.150262] systemd[1]: Failed to start ignition-fetch-offline.service - Ignition (fetch-offline).
$ ./ign-converter < base.ign
error at line 16, column 6
   15:       },
   16:     ]
           ^
invalid character ']' looking for beginning of valueError parsing spec v2 config: config is not valid
error at line 16, column 6
   15:       },
   16:     ]
           ^
invalid character ']' looking for beginning of value
$ jq < base.ign
jq: parse error: Expected another array element at line 16, column 5

Tested with jq only.

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1 tormath1 requested a review from a team June 20, 2023 11:11
@tormath1 tormath1 self-assigned this Jun 20, 2023
@tormath1 tormath1 merged commit f56d038 into main Jun 20, 2023
1 check failed
@tormath1 tormath1 deleted the tormath1/fix-base-ignition branch June 20, 2023 13:26
@tormath1
Copy link
Contributor Author

cherry-picked to:

  • flatcar-3637

@github-actions
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants