Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bake_flatcar_image.sh to allow adding several sysext overlays at once #55

Closed
jsalatiel opened this issue Apr 10, 2024 · 2 comments
Closed
Labels
kind/bug Something isn't working

Comments

@jsalatiel
Copy link
Contributor

Description

According to the script help, I should be able to run:

bake_flatcar_image.sh --release beta --vendor qemu_uefi sysext1:sysext1.raw sysext2:sysext2.raw  sysext3:sysext3.raw  ...

The problem is that only the first sysext package will be added to the final image. The remaining are just ignored.

Impact

Cant add several sysext overlays at once

Environment and steps to reproduce

  1. Create some sysext
  2. Try to add more then one using the current syntax

Expected behavior

It should add all images

@jsalatiel jsalatiel added the kind/bug Something isn't working label Apr 10, 2024
@t-lo
Copy link
Member

t-lo commented Apr 11, 2024

Thank you for reporting this! Unfortunately I'm unable to repro... We merged a bugfix yesterday which might have improved the situation: #56

I just ran

./bake_flatcar_image.sh --release alpha --vendor qemu_uefi wasmtime:wasmtime-18.0.1-x86-64.raw kubernetes:kubernetes-v1.29.2-x86-64.raw

with wasmtime and kubernetes downloaded from the bakery and ended up with a qemu image that had both included.

If it's still broken for you, could you please run

bake_flatcar_image.sh --release beta --vendor qemu_uefi sysext1:sysext1.raw sysext2:sysext2.raw  sysext3:sysext3.raw  2>&1 | tee log

and then attach log to this issue?

@jsalatiel
Copy link
Contributor Author

#56 fixed the problem for me.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants