bake_flatcar_image: Fix check for empty sysext list #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"${sysexts[@]}" expands every argument separately, while we need all
array members to be expanded into a single string for the test to work.
"${sysexts[*]}" is what we want.
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
|
Hold on |
$sysexts is an array, so we need to specify the @ index to have all entries passed to the function invocation. The current version passes only the first entry. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
|
Now it's fixed. |
pothos
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"${sysexts[@]}" expands every argument separately, while we need all array members to be expanded into a single string for the test to work. "${sysexts[*]}" is what we want.