kubernetes: Place cni binaries in /opt/cni/bin #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Containerd expects cni binaries in /opt/cni/bin. We need to make sure that directory exists before running the cp, and need to run cp in a way that doesn't result in the source directory being created in target (we only want the executables). The /opt/libexec thing was an experiment that can be removed as well, as we found another way of dealing with volume plugins. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
pothos
approved these changes
Sep 4, 2023
|
We have to make a release afterwards, that's done by pushing a tag for the current date like 20230904. |
|
Lets push a tag at the end of the week in case there's any more changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubernetes: Place cni binaries in /opt/cni/bin
Containerd expects cni binaries in /opt/cni/bin. We need to make sure that directory exists before running the cp, and need to run cp in a way that doesn't result in the source directory being created in target (we only want the executables).
The /opt/libexec thing was an experiment that can be removed as well, as we found another way of dealing with volume plugins.
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
Tested that kubeadm can create a cluster with this.