Add crio runtime support #57
Conversation
|
Thanks, a few small suggestions but otherwise it's good |
Co-authored-by: Kai Lüke <pothos@users.noreply.github.com>
Co-authored-by: Kai Lüke <pothos@users.noreply.github.com>
Co-authored-by: Kai Lüke <pothos@users.noreply.github.com>
Co-authored-by: Kai Lüke <pothos@users.noreply.github.com>
Co-authored-by: Kai Lüke <pothos@users.noreply.github.com>
|
Anything else I should do here ? |
| exit 1 | ||
| fi | ||
|
|
||
| export ARCH=x86-64 |
There was a problem hiding this comment.
To properly build for the requested architecture we would have to map this value to the image name, e.g., arm64v8/alpine for arm64 (or pass --arch if we know that docker run=podman run).
| EOF | ||
|
|
||
|
|
||
| docker save keepalived-build | tar --no-anchored --strip-components 1 -C "${SYSEXTNAME}" -xvf - layer.tar |
There was a problem hiding this comment.
Instead of doing this and FROM scratch one could also map a subfolder as /install_root into the container
There was a problem hiding this comment.
Afaik i can not map volumes during a container build.
My bad. This is my first PR and i didn't know changes made to my fork after the PR being created would also be in the PR. This PR should be only for the crio, not the keepalived.
There was a problem hiding this comment.
Right, instead of using a Dockerfile one would need to execute the commands directly in it. I think it's also having one more advantage: With docker run --rm one would always clean up even when terminated early while with the current approach docker rmi keepalived-build would only run if the script runs without error/cancellation.
|
@jsalatiel did you close this PR on purpose? |
|
It was a rookie mistake :D , but I have created another one that has already been merged |
|
Awesome! Thanks and congrats! :) |
Add crio runtime support