Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release_build #86

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Fix release_build #86

merged 4 commits into from
Sep 3, 2024

Conversation

jepio
Copy link
Member

@jepio jepio commented Sep 3, 2024

I tested the release process on a fork and there were issues:

  • cri-o is missing releases for k8s 1.31 - skip
  • nvidia-runtime needs to build with ubuntu 18 (not 20) because arm64 targets are missing
  • needed to add cross-buildx to the workflow
  • rke and k3s have '+' in filenames, this wasn't being handled correctly (asset urls contain an escape sequence)

@jepio
release_build: Skip missing CRI-O releases
a24cd55 
CRI-O is missing tags for Kubernetes 1.31.0, which was release 2 weeks ago.
Don't let this block a release.
@jepio
nvidia-runtime: Switch back to ubuntu 18.04
9357be1 
The repos do not provide a target for Ubuntu 20.04 for Arm64.
@jepio
workflows: Enable cross buildx
1444049 
The nvidia-runtime sysext build relies on cross-architecture docker builds.
@jepio
release_build: Handle filenames with non-url characters
8cfe3aa 
k3s and rke have '+' in their version number, which is part of the sysext
filename. The url mangles that into %2B and our script preserves that as the
filename of the next upload. This breaks uploading on the third run. Extract
the name of the sysext from the release assets list to fix.
@jepio jepio requested a review from tormath1 September 3, 2024 14:06
tormath1
tormath1 approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@tormath1 tormath1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, I was about to check the rke issue

@jepio
Copy link
Member Author

jepio commented Sep 3, 2024

This run illustrates the rke problem: https://github.com/jepio/sysext-bakery/actions/runs/10681647145/job/29607278902

These were the files for the previous release (i cleaned the invalid ones from the published release already):

https://github.com/flatcar/sysext-bakery/releases/download/latest/rke2-v1.29.2%2Brke2r1-arm64.raw
https://github.com/flatcar/sysext-bakery/releases/download/latest/rke2-v1.29.2%2Brke2r1-x86-64.raw
https://github.com/flatcar/sysext-bakery/releases/download/latest/rke2-v1.29.2.2Brke2r1-arm64.raw
https://github.com/flatcar/sysext-bakery/releases/download/latest/rke2-v1.29.2.2Brke2r1-x86-64.raw

and it failed when creating a new release:

Error: Failed to upload release asset rke2-v1.29.2%2Brke2r1-arm64.raw. received status code 404

@jepio jepio merged commit 3b3827e into main Sep 3, 2024
@jepio jepio deleted the fix-release branch September 3, 2024 14:16
@github-actions github-actions bot mentioned this pull request Sep 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tormath1 tormath1 tormath1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jepio @tormath1