Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: do not fail if there is no release artifact #87

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

tormath1
Copy link
Contributor

@tormath1 tormath1 commented Sep 3, 2024

if there is no release artifact, grep command will return an exit-code different from 0 so the script is failing. (https://github.com/flatcar/sysext-bakery/actions/runs/10685052349/job/29616925462)


For an unknown reason yet the last release has failed - but it's impossible to rerun has the release script expect to have existing artifacts already released.

@tormath1 tormath1 requested a review from jepio September 3, 2024 15:12
@tormath1 tormath1 self-assigned this Sep 3, 2024
@tormath1 tormath1 changed the title release: do not fail if there is not release artifact release: do not fail if there is no release artifact Sep 3, 2024
if there is no release artifact, grep command will return an exit-code
different from 0 so the script is failing.

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Copy link

@chewi chewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jq should probably do the filtering but okay.

@tormath1 tormath1 merged commit bcc3989 into main Sep 3, 2024
@tormath1 tormath1 deleted the tormath1/release branch September 3, 2024 15:28
@jepio
Copy link
Member

jepio commented Sep 3, 2024

This might actually be rate-limiting (i think i hit that as well), so we would rather want to sleep and retry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants