Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework sysext release #92

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Rework sysext release #92

merged 2 commits into from
Oct 1, 2024

Conversation

jepio
Copy link
Member

@jepio jepio commented Oct 1, 2024

Fix issues we have had with sysext releases. Previously upload failure would cause us to lose release assets, because the release gets deleted before upload.

jepio added 2 commits October 1, 2024 15:01
Artifact upload is buffered in memory, which is a limitation of the action. We
need to chunk the upload manually to work around this - by splitting it into
groups that fit within the memory limit of the worker.

We also don't need to delete the release - something that has caused us trouble
when the action fails during upload - and instead update the payload of
existing releases.  We can either keep pushing the "latest" tag (like now) or
push date base release tags and rename to "latest" manually.
@jepio jepio requested a review from t-lo October 1, 2024 13:09
@jepio jepio changed the title Reword sysext release Rework sysext release Oct 1, 2024
@jepio
Copy link
Member Author

jepio commented Oct 1, 2024

@t-lo we need this before we push the next "latest" tag. Mathieu faced issues with previous releases.

Copy link
Member

@t-lo t-lo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the quick turn-around, Jeremi!

@jepio jepio merged commit 1505915 into main Oct 1, 2024
@jepio jepio deleted the reword-sysext-release branch October 1, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants