Run rustfmt for each PR via GitHub Actions #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run CI workflow for each pull request. At the moment it only runs `cargo fmt --all --check`.
Add .rustfmt.toml to configure rustfmt per project. Note, it is unfortunately not possible to set `trailing_comma` option, because that is only available in Nightly toolchains. See also https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#trailing_comma
Disable rustfmt check in case of method calls that spread across multiple lines, which we would like to keep as-is, even if rustfmt does not provide a way to disable or configure the changes.
With disabling rustfmt checks, we are now able to run rustfmt with the following .rustfmt.toml. ``` max_width=200 fn_call_width=80 reorder_imports=false use_small_heuristics="Off" ```
pothos
reviewed
May 23, 2023
| uses: actions-rs/cargo@v1 | ||
| with: | ||
| command: fmt | ||
| args: --all --check |
There was a problem hiding this comment.
Maybe in a follow up we should also run clippy or at least cargo check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run CI workflow for each pull request. At the moment it only runs
cargo fmt --all --check.Add
.rustfmt.tomlto configure rustfmt per project.Note, it is unfortunately not possible to set
trailing_commaoption, because that is only available in Nightly toolchains.See also the doc.
Disable
rustfmtcheck in case of method calls that spread across multiple lines, which we would like to keep as-is, even ifrustfmtdoes not provide a way to disable or configure the changes.With disabling rustfmt checks, we are now able to run rustfmt with the following
.rustfmt.toml.Fixes flatcar/Flatcar#1026.
Testing done
Done via my fork.
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.