Use explicit offsets for reading and writing #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file is freshly opened and already at offset 0.
Currently the order in which the functions are called matters because they advance the offset. Some had seeks but not all. Use explicit read and write offsets to make the code more robust. Also, we have to make use of the start_block to calculate the destination even if we didn't ran into a problem yet because the way we generate the payload was giving the order we happened to write out.
dongsupark
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
download: Remove unused seek to 0
The file is freshly opened and already at offset 0.
Use explicit offsets for reading and writing
Currently the order in which the functions are called matters because
they advance the offset. Some had seeks but not all.
Use explicit read and write offsets to make the code more robust. Also,
we have to make use of the start_block to calculate the destination even
if we didn't ran into a problem yet because the way we generate the
payload was giving the order we happened to write out.
How to use
Testing done
The generic payload and the sysext payload extracts as usual.