Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop bundling the Twemoji emoji font #456

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

guihkx
Copy link
Collaborator

@guihkx guihkx commented Oct 4, 2024

Reasons:

  • Upstream doesn't want to provide the font as a TTF file.
  • The current TTF file is very outdated (4 years old), so newer emojis aren't supported anyway.
  • It doesn't make sense to include any font in the first place: Users can install any emoji font directly on the host, and Flatpak will pick it up automatically for Discord to use.

Closes #334

Reasons:

- Upstream doesn't want to provide the font as a TTF file. [1]
- The current TTF file is very outdated (4 years old), so newer emojis
  aren't supported anyway.
- It doesn't make sense to include any font in the first place: Users
  can install any emoji font directly on the host, and Flatpak will
  pick it up automatically for Discord to use.

[1] twitter/twemoji#438 (comment)
@flathubbot
Copy link
Contributor

Started test build 151823

@flathubbot
Copy link
Contributor

Build 151823 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/134906/com.discordapp.Discord.flatpakref

@guihkx guihkx merged commit 6681d62 into flathub:master Oct 4, 2024
1 check passed
@guihkx guihkx deleted the remove-twemoji branch October 4, 2024 23:06
@lionirdeadman
Copy link
Collaborator

The reason this was added is because :

  1. At the time, people were experiencing issues with Symbola being the preferred emoji on their systems which made some of the UI inconsistent with other platforms (the emojis of Symbola are monochrome and have variable width)
  2. Twemoji remains the emoji used on Discord web regardless of platform
  3. It provided consistency with the text channels since they always use Discord's own Twemoji

Anyhow, it's probably no longer necessary today. It was my bad for not updating the ttf.

@guihkx
Copy link
Collaborator Author

guihkx commented Oct 13, 2024

Thanks for explaining the reasons! I do actually remember getting monochrome emojis back in the day, even though I had noto-emoji-color installed on the host...

If I recall correctly, my solution at the time was to create a custom fontconfig file on the host to prioritize noto-emoji-color, and then I gave all Flatpak apps read-only access to it. It worked well. :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Had to install CJK fonts separately
3 participants