Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled PWAs #188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enabled PWAs #188

wants to merge 1 commit into from

Conversation

GlenKPeterson
Copy link

Added necessary filesystem access for installing Progressive Web Apps. I got a warning when accessing various google services (like Google Docs) about how I needed to allow this access in order to install the PWA. I did. It worked. Thought I'd contribute that upstream. Thanks for this flatpak - love it!

Added necessary filesystem access for installing Progressive Web Apps.  I got a warning when accessing various google services (like Google Docs) about how I needed to allow this access in order to install the PWA.  I did.  It worked.  Thought I'd contribute that upstream.  Thanks for this flatpak - love it!
@flathubbot
Copy link
Contributor

Started test build 20105

@flathubbot
Copy link
Contributor

Build 20105 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/2739/com.google.Chrome.flatpakref

@GlenKPeterson
Copy link
Author

GlenKPeterson commented Jan 30, 2023

I'm using it on a fresh install of Ubuntu Jammy LTS 22.04 after running unsnap.

@violetmage
Copy link

violetmage commented Feb 24, 2023

Good suggestion.

I'm going to look into if this can be done without requiring any "--filesystem" permissions; maybe a symlink to /export/share/applications or something, the flatpak docs are not very clear about this.

@Aqua1ung
Copy link

#197

@Danik1601
Copy link

Danik1601 commented May 9, 2023

AFAIK this will not work.

According to the #91 (comment) the permissions must look like this:

--filesystem=~/.local/share/applications:create
--filesystem=~/.local/share/icons:create

Meanwhile in your commit they look like this:

--filesystem=~/.local/share/applications
--filesystem=~/.local/share/icons

I can confirm this since I tested it on my installation.

UPD: Already noted by @Aqua1ung 😅:

#197

@violetmage
Copy link

I agree. Unless we can think of something more elegant, using .local and the :create suffix is the best option for now.

@averms
Copy link

averms commented Aug 5, 2023

Will uninstalling the Chrome flatpak remove previously installed PWAs?

@violetmage
Copy link

violetmage commented Aug 8, 2023

@averms Currently, no.

Edit: Forgot to mention, this is a good question.

We would need to figure out how to get the flatpak to export desktop files from within the sandbox. (Or run a uninstall script with a hook, which kind of defeats the point of flatpak)

I have yet to do any experimenting, but docs.flatpak.org only mentions exporting desktop files at build time. Unless some experienced flatpak-er knows otherwise, it seems like --filesystem=~/.local/share/applications:create and --filesystem=~/.local/share/icons:create is the only sandbox respecting way to do this, unfortunately.

@wjt
Copy link
Member

wjt commented Aug 9, 2023

I have yet to do any experimenting, but docs.flatpak.org only mentions exporting desktop files at build time. Unless some experienced flatpak-er knows otherwise, it seems like --filesystem=~/.local/share/applications:create and --filesystem=~/.local/share/icons:create is the only sandbox respecting way to do this, unfortunately.

https://flatpak.github.io/xdg-desktop-portal/#gdbus-org.freedesktop.portal.DynamicLauncher

Copy link

@Bohne13 Bohne13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would improve overall experience, when the user don't have to set this by himself via command-line or with 'warehouse'.

@Danik1601
Copy link

Since this change is now approved if you are to merge them, please mind #188 (comment)

@Bohne13
Copy link

Bohne13 commented Jan 25, 2024

@Danik1601 that's a good point, I have added the it with Warehouse and without the ':create' suffix.
But maybe it's better to add it for a more robust process.
If the owner @GlenKPeterson doesn't change his MR. It could be a solution to open a new one and link the actual issue/MR to it?

Gaeldrin added a commit to flathub/com.opera.Opera that referenced this pull request Feb 12, 2024
aliasbody added a commit to aliasbody/com.google.Chrome that referenced this pull request May 4, 2024
@aliasbody aliasbody mentioned this pull request May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants