Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give Slack access to system /tmp #88

Closed
wants to merge 2 commits into from
Closed

Conversation

lobner
Copy link

@lobner lobner commented Jul 9, 2020

We often use /tmp to store temporary files, of cause... but flatpak Slack does not give access to this.

It was also a problem (issue #11) with GIMP, which they solved here flathub/org.gimp.GIMP@bf7aff3 - could you possibly make the same correction?

We often use /tmp to store temporary files, of cause... but flatpak Slack does not give access to this.

It was also a problem with GIMP, which they solved here flathub/org.gimp.GIMP@bf7aff3 (issue: flathub/org.gimp.GIMP#11) - could you possibly make the same correction?
@flathubbot
Copy link
Contributor

Started test build 23380

@flathubbot
Copy link
Contributor

Build 23380 failed

@flathubbot
Copy link
Contributor

Started test build 23383

@flathubbot
Copy link
Contributor

Build 23383 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/22460/com.slack.Slack.flatpakref

@egilkv
Copy link

egilkv commented Aug 12, 2020

Just voicing in my support for the feature. The default Gimp behaviour of playing games with /tmp breaks an important feature in my Ubuntu: Opening an image from the Firefox browser in the Image Viewer, and then from the viewer selecting Open With->GIMP. The browser image is stored in /tmp/mozilla_username0/something.jpg which Gimp cannot find.

@shaicoleman
Copy link

shaicoleman commented Jan 31, 2021

For security reasons, it's not a good idea to give access to /tmp by default.
If you need to access /tmp you can always configure it manually,
e.g. sudo flatpak override com.slack.Slack --filesystem=/tmp

@vchernin
Copy link
Contributor

vchernin commented May 5, 2021

You can also edit a flatpak's permissions graphically with flatseal.

@johnnyapol
Copy link

electron/electron#19159 (which was merged and should be landing in electron 14) makes electron apps use the GtkFileChooserNative which means file uploads would go through the flatpak portal and therefore no overrides would be needed. Unfortunately, electron 14 isn't released yet (and it would take time for slack to upgrade to it), but this will resolve this issue at some point in the future

@WhyNotHugo
Copy link
Collaborator

I'm going to close this based on the security issues mentioned in comments above.

Electron has already fixed this via electron/electron#19159, once Slack updates their electron version to at least 14, picking any file will work natively.

@WhyNotHugo WhyNotHugo closed this Sep 22, 2021
@lobner lobner deleted the patch-1 branch September 22, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants