Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom flag support #476

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add custom flag support #476

wants to merge 1 commit into from

Conversation

Tomaszal
Copy link

@Tomaszal Tomaszal commented Dec 13, 2023

Allows users to specify persistent flags via code-flags.conf file. Implementation taken from Spotify Flatpak.

This is an alternative to #373 that would allow users to fix #281 without their changes being reset every update. It can also potentially be useful for other things, but I imagine this would be the primary use for now.

@flathubbot
Copy link
Contributor

Started test build 87601

@flathubbot
Copy link
Contributor

Build 87601 failed

@Tomaszal
Copy link
Author

Build failed with the following error:

{
    "errors": [
        "finish-args-unnecessary-xdg-config-access"
    ],
    "warnings": [
        "flathub-json-redundant-only-arches"
    ]
}

I tried to build it locally and I get the same error currently even without this change. The way code-flags.conf is accessed is no different to flatpak-vscode-first-run is accessed, so I don't think this change causes this build error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to start – Unable to open X display / Failed to connect to Wayland display
2 participants