Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong icon (using macOS only variant) #62

Closed
neilcsmith-net opened this issue Sep 17, 2024 · 8 comments
Closed

Wrong icon (using macOS only variant) #62

neilcsmith-net opened this issue Sep 17, 2024 · 8 comments

Comments

@neilcsmith-net
Copy link

The flatpak package is using the wrong NetBeans icon. The .icns file is intended for macOS, which is more noticeable now that it has been changed to follow macOS design guidelines.

The standard icon that should be used on other OS can be found at https://github.com/apache/netbeans-nbpackage/blob/master/src/main/resources/org/apache/netbeans/nbpackage/apache-netbeans.svg and https://github.com/apache/netbeans/blob/master/platform/core.startup/src/org/netbeans/core/startup/frame1024.png

@patriziobruno
Copy link
Collaborator

I'm open to contributions 😉

@neilcsmith-net
Copy link
Author

See apache/netbeans#7755 I don't intend to contribute to downstream packaging that I'm not using so can't test. I am trying to help make this easier for those who do.

@patriziobruno
Copy link
Collaborator

Thanks for the heads-up

@patriziobruno
Copy link
Collaborator

patriziobruno commented Sep 21, 2024

@neilcsmith-net I can't find any of those files - nor any other high-resolution icons - in the binary release. Is there any intention of introducing them in the future?

@neilcsmith-net
Copy link
Author

neilcsmith-net commented Sep 21, 2024

They will hopefully be in the NB24 zip release but not in NB23. The links in the report work now. The NBPackage SVG is used in the ASF and Codelerity DEB, RPM and AppImage. I guess you could also extract from the DEB rather than zip?

@patriziobruno
Copy link
Collaborator

I considered using the deb package, but I'd rather stick to a distro agnostic package, since the runtime I'm using is not Debian based. Since NB24 should include the high res icons in formats different from icns, I'll address this in next release.

@neilcsmith-net
Copy link
Author

Up to you, but the ASF deb and rpm are effectively distro agnostic once extracted. The contents of /usr/lib/apache-netbeans are a bit-for-bit copy of the zip file contents.

In both there's a 48x48 png as required by the icon spec, along with the svg, inside /usr/share

@neilcsmith-net
Copy link
Author

Thanks @patriziobruno !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants