Avoid aliasing id & rev if prop names are already there #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of obscure historical reasons, we have an `id` property in our CouchDB
documents. So, when one GET-s such a document with `curl`, they'll see something
like:
{ _id: '811b77f35fca01bae6eb9b8ad67becc4',
_rev: '1-c70b6027c1d75917cef89710a6ef02f0',
id: '10001',
name: 'Sorell Hotel Aarauerhof',
ratingStars: 3,
...}
However, if we `get()` such a document with cradle, our `id` value disappears,
becoming a non-enumerable property with a value of `811b77f...`. That change
helps avoiding such a situation.
|
We have same issue here. I don't want |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of obscure historical reasons, we have an
idproperty in our CouchDB documents. So, when one GET-s such a document withcurl, they'll see something like:However, if we
get()such a document with cradle, ouridvalue disappears, becoming a non-enumerable property with a value of811b77f.... That change helps avoiding such a situation.