Add a new cache mode 'follow' #291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than specifying 'true' or 'false' for the 'cache' option, specifying 'follow' will uses a changes feed to track external modification to cached documents. Only documents that have been cached during normal write-through operation will be updated. This is useful if you have a system where multiple clients may write directly to the database without going through a single cache. Note: This could be made more optimal for cases where not all changes in the feed are cached as it pulls the full document content in the change feed. Maybe a mode 'follow-lite' could enable a lightweight change feed followed by additional fetch if it is found that a changed document is cached. If, for a particular app however, changes are likely to occur externally to documents in the cache, the existing 'include_docs' mode is probably OK.
…follow' cache mode.
|
My personal opinion would be to get rid of the cache altogether. It shouldn't be in the purview of a database access library to cache database operations, and usually these caches have more costs than benefits. Cache will be disabled by default in 1.0.0, but I'd even push for removing the cache feature completely from cradle. I don't know how others feel about this change, though. |
|
I've had issues with the cache in the past +1 to remove it. |
… of the cache for specific databases.
abutcher-gh
force-pushed
the
follow-cache
branch
from
fb82e09
to
19f7ee4
Compare
export-mike
approved these changes
Apr 19, 2021
abutcher-gh
force-pushed
the
follow-cache
branch
from
cf527ff
to
bfe1c9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than specifying 'true' or 'false' for the 'cache' option,
specifying 'follow' will use a changes feed to track external
modification to cached documents. Only documents that have been
cached during normal write-through operation will be updated.
This is useful if you have a system where multiple clients may write
directly to the database without going through a single cache.
Note: This could be made more optimal for cases where not all changes
in the feed are cached as it pulls the full document content in the
change feed. Maybe a mode 'follow-lite' could enable a lightweight
change feed followed by additional fetch if it is found that a changed
document is cached. If, for a particular app however, changes are
likely to occur externally to documents in the cache, the existing
'include_docs' mode is probably OK.