-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the host path when current_folder points to the document storage #1007
Conversation
Please, conform to the coding style of the rest of the project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would have been faster, if github had the ability to deal with suggestions involving more than one line.
Addressed also: xhorak@b3c3f56#r111467974 |
src/file-chooser.c
Outdated
g_autoptr(GVariant) value = | ||
g_variant_lookup_value (arg_options, "current_folder", G_VARIANT_TYPE_BYTESTRING); | ||
|
||
if (value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niggle: move the { to the next line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from that, this looks good to me now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation is wrong too
The commits should be squashed and turned into the first one before landing. |
If the application stores the path of the last saved file for later save requests to open the same directory it currently points to /run/user/<uid>/doc/<doc_id> using 'current_folder' option. The patch uses the <doc_id> to lookup the host path from the document portal and replaces the current_folder with that. Resolves: flatpak#982
@ebassi could we please finish this? |
From my perspective, this is good to go |
Same here, so I guess I get to press the green button. 😄 |
So while it helps re-open the folder with a "nice name" we still save an XDG document path. Is it possible we have this feature exposed somehow ? Via DBus ? Or maybe it is already doable ? @matthiasclasen @ebassi ? |
Isn't unprivileged code always seeing an XDG document path part of the point for ensuring that unnecessary information that may be contained in the names of ancestor folders isn't leaked? |
@lissyx Please, open an issue. Commenting on a closed merge request isn't going to help in tracking issues. |
@ssokolow The document storage is not for avoiding "leaking" the original path: it's for providing access to a file. There's no expectation of privacy to be "leaked" in the first place. |
I was asking a question, not reporting a bug |
In that case, I'm mildly surprised that the FUSE filesystem doesn't just present a grant for It'd make it much easier for things like some text editors' |
So was privacy provided just by coincidence with no plan of supporting this aspect in the future? I'm curious if my expectations are really out of the scope of the project, but what I seek in Flatpak is mostly what I used to seek in browsers which is keeping unknown, often hostile by design programs in check including privacy ("data security") too to some degree. |
Addressing issue #982