Sort implementations based on the UseIn key
#670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgesStavracas
requested changes
Dec 2, 2021
GeorgesStavracas
requested changes
Dec 3, 2021
|
The title of the first commit should be something like Please add a description of your changes, what are they fixing, and how it is done, in the commit message. Please keep in mind that commit message lines are limited to 72 characters in length. |
Marukesu
force-pushed
the
sort-impl-use-in
branch
3 times, most recently
from
247b67f to
8f5354e
Compare
|
it should be all good now. |
makes the implementations list sort supported backends first. this fixes an possible issue in org.freedesktop.portal.Settings that they would call an fallback backend first instead of the supported one.
Marukesu
force-pushed
the
sort-impl-use-in
branch
from
8f5354e to
0bf8817
Compare
GeorgesStavracas
approved these changes
Dec 3, 2021
|
Thanks, this looks good to me now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes an possible issue in
org.freedesktop.portal.Settingsthat they would call an fallback backend first instead of the supported one, possibly breaking theorg.freedesktop.appearance.color-schemesupport, if both implements it.