update and improve error_budget_pie
function
#249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
error_budget_pie
function was representing the individual errors as fractions of a linearly summed total error. Such a representation can be rather misleading since the actual total error corresponds to the individual errors summed in quadrature, not linearly.This PR updates the
error_budget_pie
function to improve the visual representation of the individual error contributions. In the new versionSo the new version gives an accurate graphical representation of the individual errors summed in quadrature and the sizes of the wedges have an intuitive interpretation in terms of the individual variance contributions that can be summed linearly. Furthermore, the numbers on the labels now exactly correspond to the results of
flavio.sm_error_budget
, also when small contributions are grouped together under "other" (this was not the case before since "other" always corresponded to small errors summed in quadrature), and summing all the numbers on the labels in quadrature now exactly yields the actual total error.