Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue in Constraints.add_constraint #255

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

peterstangl
Copy link
Collaborator

No description provided.

@DavidMStraub
Copy link
Contributor

Why aren't you keeping the existing behaviour as default to preserve backward compatibility?

@peterstangl
Copy link
Collaborator Author

I think that's what I'm doing now with this PR using the argument parameter_object=False. I introduced an issue in a previous commit in PR #247 where I actually broke backward compatibility. The present PR should restore it.

@DavidMStraub
Copy link
Contributor

Perhaps parameter_object might benefit from a different name that fits to the fact that it's a boolean, not a parameter object

@peterstangl
Copy link
Collaborator Author

Maybe something like is_parameter_constraint? 🤔 The main point is just that this should only be applied to parameter constraints and not to measurement constraints.

@peterstangl peterstangl merged commit aa153bb into flav-io:master Jul 16, 2024
4 checks passed
@peterstangl peterstangl deleted the ff_import_fix branch July 16, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants