Skip to content
This repository has been archived by the owner on Apr 1, 2019. It is now read-only.

NOTICE: Ending support for this gem #83

Closed
flavorjones opened this issue Mar 24, 2019 · 15 comments
Closed

NOTICE: Ending support for this gem #83

flavorjones opened this issue Mar 24, 2019 · 15 comments

Comments

@flavorjones
Copy link
Owner

flavorjones commented Mar 24, 2019

Ahoy, Rubyists.

This issue, related to #80 (and through that, to #78 and #79), intends to:

  1. Give public notice of ending support for chromedriver-helper, and deprecating it in favor of the webdrivers gem which has very nearly a superset of the functionality.
  2. Provide a punch list to track what needs to be done to wind down this gem responsibly, and provide transparency into the state of support/deprecation.

More to follow.

@flavorjones
Copy link
Owner Author

Rationale

  1. I have not coded in Rails or used chromedriver in quite some time, and so I'm pretty far from the day-to-day needs of most users of chromedriver-helper. To be honest, there are some design decisions that need to be made, and work that needs to be done; and I don't have the well-formed opinions or the motivation that a daily user of the gem might have.
  2. The webdrivers gem is well-maintained, is very nearly a superset of the functionality of this gem (and supports all major webdrivers), and further has maintainers interested in providing what little this gem does that's not already provided.
  3. There's value to the community in having one well-supported and well-maintained gem that handles a given concern; and IMHO there is little-to-nothing to innovate on in this space.

@flavorjones
Copy link
Owner Author

flavorjones commented Mar 24, 2019

Punchlist

Things I think need to be done in order to complete deprecation, ideally by 2019-03-31:

@flavorjones flavorjones pinned this issue Mar 24, 2019
@flavorjones
Copy link
Owner Author

/cc @tenderlove for formal notification of rails-core contributors

@flavorjones
Copy link
Owner Author

ruby-talk notification is at http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-talk/440018

flavorjones added a commit that referenced this issue Mar 24, 2019
flavorjones added a commit that referenced this issue Mar 24, 2019
- post-install message
- updating summary and description

related to #83
flavorjones added a commit that referenced this issue Mar 24, 2019
@flavorjones
Copy link
Owner Author

flavorjones commented Mar 24, 2019

v2.1.1 has been shipped with a post-install-message deprecation notice, and updated gemspec summary and description. Post-install message is:

  +--------------------------------------------------------------------+
  |                                                                    |
  |  NOTICE: chromedriver-helper is deprecated after 2019-03-31.       |
  |                                                                    |
  |  Please update to use the 'webdrivers' gem instead.                |
  |  See https://github.com/flavorjones/chromedriver-helper/issues/83  |
  |                                                                    |
  +--------------------------------------------------------------------+

@connorshea
Copy link

@flavorjones you should include a message in the Changelog as well.

@guilleiguaran
Copy link

Changed in Rails, new Rails 6.0.0 apps will ship webdrivers instead of chromedriver-helper

@pixeltrix
Copy link

@guilleiguaran should we also backport that to 5-2-stable as well?

@nodanaonlyzuul
Copy link

Thanks @flavorjones (and everyone else who has contributed) - enjoy that well earned, final punch-list item.

@ioquatix
Copy link

Thanks for being an awesome maintainer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants