-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in 2.9.0: string css attributes scrubbing #202
Comments
Thanks for reporting this! I'll take a look. |
Using this as the test script: #!/usr/bin/env ruby
require 'loofah'
text = <<~EOF
<span style="font-size: 36px; font-family: 'AvenirNext-Regular';">This style gets stripped</span>
<span style="font-size: 36px; font-family: 'Avenir Next';">This style does not get stripped</span>
EOF
puts Loofah::VERSION
puts Loofah.fragment(text).scrub!(:strip)
puts Loofah.fragment(text).scrub!(:prune) I git-bisected and agree that this commit introduced the issue:
|
PR in #203 |
v2.9.1 has been released fixing this issue. Thanks again for reporting it! |
@flavorjones No thank you, you're the one doing the great work here : ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This commit bf13d48 seem to scrub all css attribute of type "string", which impact font-family values that are not single word.
For example, the two examples in #130 don't work anymore.
The text was updated successfully, but these errors were encountered: