-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer cc and c++ when using CMake on FreeBSD #139
Conversation
also split fedora out into two jobs (unit and examples)
337e588
to
6d65769
Compare
@mudge I've pushed a commit onto this branch that has CI set up on FreeBSD. You can see the pristine state of those CI jobs at #140 which seem to be failing on:
Let's see what happens! 🤞 |
🎉 the unit tests are passing in this PR because you've configured the compiler! whee! Do you want to try to address the |
I'm not too familiar with |
As of FreeBSD 10.X, clang is installed as the default compiler with "cc" and "c++" as aliases to "clang" and "clang++" respectively.
By default, "make" on FreeBSD is not compatible with the GNU make expected by the example libraries that test:examples will attempt to compile. GNU make _is_ available for FreeBSD but isn't installed by default so we explicitly download it and set the MAKE environment variable so MiniPortile will use it.
As As a middle ground, I've added e0de764 which explicitly installs |
@mudge That's perfect! Thank you for doing that, the bsd job is green: https://github.com/flavorjones/mini_portile/actions/runs/8661982917/job/23757576215?pr=139 I'll merge and cut a release later today! |
Just shipped 2.8.6: Release 2.8.6 / 2024-04-14 · flavorjones/mini_portile |
As of FreeBSD 10.X, clang is installed as the default compiler with "cc" and "c++" as aliases to "clang" and "clang++" respectively.