Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] MapController.move does not emit MapEventMove with passed id argument #1542

Closed
hidea opened this issue Jun 2, 2023 · 2 comments · Fixed by #1532
Closed

[BUG] MapController.move does not emit MapEventMove with passed id argument #1542

hidea opened this issue Jun 2, 2023 · 2 comments · Fixed by #1532
Labels
bug This issue reports broken functionality or another error

Comments

@hidea
Copy link

hidea commented Jun 2, 2023

What is the bug?

MapController move with id is not reflected in the event.

How can we reproduce it?

mapController.move(LatLng(position.latitude, position.longitude),10, id: "current");

Event callback id contains null.

FlutterMap(
  ...
  options: MapOptions(
    onMapEvent: (event) {
      if (event is MapEventMove) {
        // event.id is null
      }
    }
  )
}

Do you have a potential solution?

Perhaps the passing of the id is missing here?

final movementEvent = MapEventWithMove.fromSource(
targetCenter: newCenter,
targetZoom: newZoom,
oldCenter: oldCenter,
oldZoom: oldZoom,
hasGesture: hasGesture,
source: source,
);

Platforms

Web, iOS

Severity

Minimum: Allows normal functioning

@hidea hidea added bug This issue reports broken functionality or another error needs triage This new bug report needs reproducing and prioritizing labels Jun 2, 2023
@ibrierley
Copy link
Contributor

I think maybe this is fixed by #1534

@JaffaKetchup JaffaKetchup linked a pull request Jun 2, 2023 that will close this issue
@JaffaKetchup JaffaKetchup added non-fatal and removed needs triage This new bug report needs reproducing and prioritizing labels Jun 2, 2023
@JaffaKetchup
Copy link
Member

Thanks for reporting. This is fixed in #1532 (434ce32), which was originally from #1534. It should appear in the next v5 (pre?)release.

@JaffaKetchup JaffaKetchup changed the title [BUG] id of move function in MapController is not reflected in the event. [BUG] MapController.move does not emit MapEventMove with passed id argument Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue reports broken functionality or another error
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants