Multiple Improvements & v5 Release Preparation

[JaffaKetchup]

Includes a major refactoring and reorganization with the aim of reducing the scope of responsibility for source files.

For changes to functionality and API, see the CHANGELOG. Note that this PR includes breaking changes.

Example application improvements:

• Reorganized drawer menu
• Added welcome dialog to example app when running at 'demo.fleaflet.dev' only
• Removed unnecessary/bloat demo pages
• Overhauled Marker Layer page
• Improved other demo pages

Other meta changes:

• Updated CHANGELOG and pubspec.yaml
• Fixed GitHub not being able to interpret license
• Add automated pub.dev publishing action on tag creation
• Cut ties with leaflet.js in README
  I think we're starting to progress in our own direction, and I want to reduce the expectations for feature parity with it. Of course, I'm happy to look at it for inspiration as we sometimes do.

  It is true that the concepts of this library are similar, but our aim is not necessarily feature parity - we want to implement core features that there's high demand for, and don't really suit plugin architectures.
  This is partially because FM is on a much smaller scale than leaflet.js, and there's only 4 maintainers, so we rely on the community for a lot of feature additions - hence, we prefer plugins, as it also reduces the maintenance cost for us.

[rorystephenson]

Hey @JaffaKetchup nice work!

Great to see the demo app too.

FYI I just found a bug I introduced in the v4 changes which is worth including in this: #1534 .

TBH it's probably worth cherry-picking and releasing as a hotfix on v4 as well because it breaks tileupdatetransformers that rely on movement ids (like the one for animated movement in the example app).

[JaffaKetchup]

Hi @rorystephenson,
Great spot! I've copied your fix into this manually in commit 434ce32 to avoid conflicts, and added you as a co-author.
EDIT: Not sure about cherry picking backwards for this, as it's still quite an unused feature and doesn't prevent movement - I'm happy for it to wait for v5.

[ibrierley]

I'm pretty ok with all of this, just a note, my mobile is bust atm, so just testing on web, so some bits like rotation I haven't tested, but don't see any obvious reason why that should be changed.

Main ponderings.

I think there's a few examples that have been removed, but I feel like some of them are handy, that keep cropping up like anchors and maxBounds, so wondering if they should be kept. Not sure the removal outweighs the "bloat".

Any reason for moving some core stuff to misc ? I don't really care tbh, just sometimes in general I find misc folders a kind of slack dumping ground :D.

Couple of bits that are making me scratch my chin, but I don't think are related to this PR (but maybe V4?), but wondering if we should double check before releasing...

The Reset Tile Layer example, doesn't seem to display the tiles after a reset. I don't think they did in very old releases, but then did in recent ones unless I'm mistaken...
I note in the example at https://demo.fleaflet.dev/#/ on my max two finger zoom doesn't work. I know there's been a few odd mac related things that probably aren't flutter_map specific, but may be worth double checking as well (it may just be me).

[JaffaKetchup]

@ibrierley Thanks.

I think there's a few examples that have been removed, but I feel like some of them are handy, that keep cropping up like anchors and maxBounds, so wondering if they should be kept. Not sure the removal outweighs the "bloat".

I removed the following example pages:

• Fallback URL for AssetTileProvider
  I originally removed this because I considered it to be similar to the same functionality for the NetworkTileProvider - happy to add it back if you think it would be better
• Live Location demo & Live Location feature in Map Controller page
  This didn't work anyway, and there's much better solutions with plugins, and we don't have to deal with permissions
• Network Tile Provider page
  With the changes made to the providers previously, this page is redundant and is the same as the Home page
• Widgets
  There's nothing special anymore - since (I think?) v2, widgets can just be inserted directly into children, and I don't think this needs much demonstration

I consolidated the following pages into one new Markers page:

• Tap To Add
• Marker Rotation
• Marker Anchor

Any reason for moving some core stuff to misc ? I don't really care tbh, just sometimes in general I find misc folders a kind of slack dumping ground :D.

That's precisely what it is! I would say the most 'core' part of this library is the widget and widget state. This was never in "core". 'core' suggests utmost importance to me, and things that are coupled everywhere, whereas 'misc' or 'utils' implies shared code but that is independent. All files in "misc" are independent (not closely related to FM state, etc.).

The Reset Tile Layer example, doesn't seem to display the tiles after a reset. I don't think they did in very old releases, but then did in recent ones unless I'm mistaken...

As far as I can see, the example is broken. I don't know when it broke, but I'm assuming it broke with the Tile Layer rewrites. But is resetting even useful anymore? Not sure myself.

I note in the example at https://demo.fleaflet.dev/#/ on my max two finger zoom doesn't work. I know there's been a few odd mac related things that probably aren't flutter_map specific, but may be worth double checking as well (it may just be me).

Mac gestures have been buggy for ages. I unfortunately can't check (don't have a touch screen Mac). I'm thinking that the next update should be a gestures cleanup and addition of rotation support with mice/cursor, but that's just a pipedream at the moment.

[ibrierley]

I think I'm fine with all of it, except I'd quite like maxBounds example to be retained (or included as part of another one).

[rorystephenson]

Hey @JaffaKetchup one little comment/question. Sorry I didn't have time to review this and raise it before merging.