Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepared for release of 0.14.0 #1022

Merged
merged 3 commits into from
Sep 13, 2021
Merged

Prepared for release of 0.14.0 #1022

merged 3 commits into from
Sep 13, 2021

Conversation

kengu
Copy link
Contributor

@kengu kengu commented Sep 10, 2021

Closed #1021

@kengu kengu requested a review from johnpryan September 10, 2021 20:56
@kengu kengu mentioned this pull request Sep 10, 2021
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some pub.dev dependencies can be updated, including but not limited to async and http. If you're publishing a major version, it would be nice for the dependencies to be updated?

Also resolving major bug #1002 by #1003 would be good. Did #989 ever get merged?

@kengu
Copy link
Contributor Author

kengu commented Sep 10, 2021

@JaffaKetchup Updated dependencies now. I'm a bit worried about #1002, #1003 and #989. All of them seems a bit hairy. In the case of #989, I think the correct thing to do would is to refactor how the MapState is bootstrapped to remove the async nature of member initialisations. I short, I think we should release what we have, and do a 0.14.1 bugfix release later on. There is a lot of good stuff that shouldn't be held back anymore.

Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I understand that, and I agree. These feature additions are really cool and who knows how long the aforementioned PR's will take.

@tlueder
Copy link
Contributor

tlueder commented Sep 13, 2021

Hi,

#1002 Should be fixed before the release.

As this is a real blocker for me. And it seem that it is a bug from the null safety migration.
Because moveAndRotate uses the id only to call move and rotate, which both don't require a non null id.
Only moveAndRotate does.

@johnpryan johnpryan merged commit 0e8f909 into master Sep 13, 2021
@JaffaKetchup JaffaKetchup deleted the releases/0.14.0 branch June 19, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 0.14.0
4 participants