Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EPSG4326 parameter difference with Leaflet.js #1135

Merged
merged 4 commits into from
Apr 10, 2022
Merged

Fix EPSG4326 parameter difference with Leaflet.js #1135

merged 4 commits into from
Apr 10, 2022

Conversation

yeleibo
Copy link
Contributor

@yeleibo yeleibo commented Jan 19, 2022

image

@ibrierley
Copy link
Contributor

Can you describe what the difference this may make to users that they would notice when testing or using ?

@yeleibo
Copy link
Contributor Author

yeleibo commented Jan 26, 2022 •
edited
Loading

when map option crs set with EPSG4326,if toTransformation() param set 1 the map load will error.
my exmaple: https://github.com/yeleibo/flutter_map .
Leaflet.js doc: https://github.com/Leaflet/Leaflet/blob/fb0b2a169ebde77a8bed1715bb07d436b60328a2/docs/examples/wms/wms.md
image
Screenshot_2022-01-26-10-19-56-985_me jpryan flut

@JaffaKetchup JaffaKetchup changed the title fix EPSG4326 parameter difference with leftlet.js Fix EPSG4326 parameter difference with Leaflet.js Jan 28, 2022
@JaffaKetchup
Copy link
Member

@yeleibo Can you please pull upstream, so I can re-run checks and review (and merge)? Thanks,

@yeleibo
Copy link
Contributor Author

yeleibo commented Feb 21, 2022

@yeleibo你能拉到上游，所以我可以重新运行检查和审查（和合并）？谢谢，

yes,I already pull upstream！

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Mar 23, 2022
@JaffaKetchup JaffaKetchup self-requested a review April 10, 2022 12:46
JaffaKetchup
JaffaKetchup approved these changes Apr 10, 2022
View reviewed changes
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, new example page seems to work. Bit of an odd projection, never used it before, but I guess this has fixed something. Will merge now...

@JaffaKetchup JaffaKetchup merged commit 0910ed6 into fleaflet:master Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaffaKetchup JaffaKetchup JaffaKetchup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yeleibo @ibrierley @JaffaKetchup