possible fix for opacity widget causing hairlines and possible flicker #1169
Conversation
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
I'll try to test soon |
There was a problem hiding this comment.
@ibrierley
Unfortunately I can't test this. I've tried running the latest 'master' branch example app on the Home page, and I just can't see the white lines that I've seen before. Therefore I wouldn't be able to know if this has done anything?
Maybe this has fixed itself in Flutter updates? Alternatively (and I'm not sure why this would make a difference), I had to update the compileSdkVersion & targetSdkVersion to '31', and the ext.kotlin_version to '1.6.20'?
Can you try on your side, to see if you still get the issue?
|
Did you try with rotation disabled ? i.e interactiveFlags: InteractiveFlag.all & ~InteractiveFlag.rotate in MapOptions. |
|
Ah no probably not - I just used the main example. My mistake: I'll try again tomorrow :) |
|
I've tested this and it works great. Nice work @ibrierley! |
This is a possible workaround for the flicker and hairline issues #1126 & #1156
It removes the Opacity widget (I'm not sure this is going to get fixed easily by Flutter, so think we will have to create our own), and introduces the opacity to the RawImage instead.
This feels possibly logical, however, I'm not confident on the Animated Tile stuff, so this may not be exactly the same.... I assume the opacity at this position is for fading in new tilesets/zooms ? If anyone knows this part of the code, it would be useful to give some thoughts, as I'm a little unsure how to test it properly.
It would also be useful for those with the initial problems to see if it helps.
Rotation needs to be disabled for the original hairline type issues to appear, i.e interactiveFlags: ~InteractiveFlag.rotate in MapOptions