Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Center scroll wheel zoom on mouse pointer #1191

Merged
merged 6 commits into from
Mar 20, 2022
Merged

Center scroll wheel zoom on mouse pointer #1191

merged 6 commits into from
Mar 20, 2022

Conversation

pmjobin
Copy link
Contributor

@pmjobin pmjobin commented Mar 18, 2022

This modifies the behaviour of scroll wheel zooming so that it mimics other map packages (such as Google Maps) by pinning the center of scaling under the mouse pointer. This works regardless of the rotation of the map.

@JaffaKetchup
Copy link
Member

@pmjobin Will try to test soon. Thanks for your contribution!

JaffaKetchup
JaffaKetchup requested changes Mar 20, 2022
View reviewed changes
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be able to merge this, the checks need to be satisfied. To do this, please run dart format . --fix in your console.

@JaffaKetchup
Copy link
Member

@pmjobin @a14n How will #1191 and #1182 work together? Will they interfere?

@JaffaKetchup JaffaKetchup mentioned this pull request Mar 20, 2022
Merged
@JaffaKetchup JaffaKetchup self-requested a review March 20, 2022 14:05
JaffaKetchup
JaffaKetchup requested changes Mar 20, 2022
View reviewed changes
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to keep annoying you! This also needs to be fixed to appease the checks:

lib/src/gestures/gestures.dart:3:[8] - unused-import - Unused import: 'dart:math'. Try removing the import directive.

@JaffaKetchup JaffaKetchup self-requested a review March 20, 2022 14:08
JaffaKetchup
JaffaKetchup reviewed Mar 20, 2022
View reviewed changes
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will test changes soon, now auto-checks are all good :)

@pmjobin
Copy link
Contributor Author

pmjobin commented Mar 20, 2022

Thanks for your help!

ibrierley
ibrierley approved these changes Mar 20, 2022
View reviewed changes
Copy link
Contributor

@ibrierley ibrierley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and thanks! Tests good for me with and without rotation in chrome and android.

@JaffaKetchup
Copy link
Member

Testing now...
Will have to resolve those conflicts before merge.

@a14n
Copy link
Contributor

a14n commented Mar 20, 2022

To resolve the conflict you have to replace MapEventSource.custom with MapEventSource.scrollWheel

@JaffaKetchup JaffaKetchup self-requested a review March 20, 2022 17:32
JaffaKetchup
JaffaKetchup approved these changes Mar 20, 2022
View reviewed changes
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems to work.

@JaffaKetchup JaffaKetchup merged commit aec8274 into fleaflet:master Mar 20, 2022
@JosefWN JosefWN mentioned this pull request Sep 8, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaffaKetchup JaffaKetchup JaffaKetchup approved these changes

@ibrierley ibrierley ibrierley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmjobin @JaffaKetchup @a14n @ibrierley