Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial fit bounds #1216

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Fix initial fit bounds #1216

merged 2 commits into from
Apr 19, 2022

Conversation

ibrierley
Copy link
Contributor

Fix for problem where bounds sometimes breaks on an initial layoutBuilder that doesn't have a valid constraints size, and causes fixBounds to break. (sorry created a branch here, but didn't mean to!)

@ibrierley ibrierley requested review from JaffaKetchup and kengu April 14, 2022 16:27
Copy link
Contributor

@kengu kengu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not tested locally thought

@JaffaKetchup
Copy link
Member

Sorry I haven't been able to test today, I've been quite busy. I'll try to get it done ASAP.

@JaffaKetchup
Copy link
Member

Will be able to test in the next hour...

@JaffaKetchup JaffaKetchup linked an issue Apr 19, 2022 that may be closed by this pull request
12 tasks
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on web, but should be same on all platforms. Haven't used a broken test case from before, but this hasn't broken anything, and the code looks good.

As a side note, maxBounds has now completely broken, but this is not the cause of this.

@JaffaKetchup JaffaKetchup merged commit 0c78001 into master Apr 19, 2022
@JaffaKetchup JaffaKetchup deleted the fix_initial_fit_bounds branch April 19, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] bounds potentially broken in MapOptions
3 participants