Changed Attribution Methods #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new `AttributionWidget` intended as replacement Updated README & CHANGELOG Updated pubspec.yaml
ibrierley
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline with #1040, this deprecates the old method of attribution via
attributionBuilder, and replaces it with a new layer widget:AttributionWidget.AttributionWidgetis intended to be used insidenonRotatedChildren. Therefore, both the README, main example page, and in-code documentation reflect this. It now also aligns with the map as expected, unlike the old method.Also provided is a quicker way to attribute by using
AttributionWidget.defaultWidget, which automatically styles the widget similar to how it is seen elsewhere on the Internet. The example and README use this for demonstration.Resolves #1040 by replacing #1012.