fix for double click not keeping track with event position #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
Nice! Looks correct to me, I can zoom and double-tap my way in/out and still remain in the same geographical position relative to the cursor. |
JaffaKetchup
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge this just yet, but is for testing currently. Fixes #1265
Previously double click wouldn't zoom to correct position. This should fix that, and refactors mousewheel zoom to use the same code now, in a separate method.
Also slight change is the animation easing on double click. There is a bug (existing before this change), where a zoom doesn't follow the correct linear path. The easing doesn't help here, so keeping it simple, so it's slightly less obvious, but ideally needs a fix in the future.