Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed fix for unsymmetrical anchored markers disappearing #1291

Merged
merged 11 commits into from
Jul 7, 2022
Merged

Proposed fix for unsymmetrical anchored markers disappearing #1291

Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
85ad5ed
Proposed fix for unsymmetrical anchored markers disappearing
aytunch Jun 28, 2022
aa04932
changed width&height to the new values in Positioned
aytunch Jun 28, 2022
a7611ee
added prints
aytunch Jun 28, 2022
24299ed
Update marker_layer.dart
aytunch Jun 28, 2022
64ce554
Update marker_layer.dart
aytunch Jun 28, 2022
26a4551
Update marker_layer.dart
aytunch Jun 28, 2022
7c848c3
fixed calculations after debug and tested
aytunch Jun 29, 2022
90c91be
changed var to final
aytunch Jun 29, 2022
9967901
fixed typos
aytunch Jun 29, 2022
52b2352
changed naming convention for sw and ne to make more sense
aytunch Jun 29, 2022
4bbf1cb
added comment for the coordinate system confusion of Anchors
aytunch Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions lib/src/layer/marker_layer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,10 +261,18 @@ class _MarkerLayerState extends State<MarkerLayer> {
_pxCache[i] = pxPoint;
}

final width = marker.width - marker.anchor.left;
final height = marker.height - marker.anchor.top;
final sw = CustomPoint(pxPoint.x + width, pxPoint.y - height);
final ne = CustomPoint(pxPoint.x - width, pxPoint.y + height);
// See if any portion of the Marker rect resides in the map bounds
// If not, don't spend any resources on build function.
// This calculation works for any Anchor position whithin the Marker
final leftPortion = marker.width - marker.anchor.left;
final rightPortion = marker.anchor.left;
final topPortion = marker.height - marker.anchor.top;
final bottomPortion = marker.anchor.top;

final sw =
CustomPoint(pxPoint.x + rightPortion, pxPoint.y - topPortion);
final ne =
CustomPoint(pxPoint.x - leftPortion, pxPoint.y + bottomPortion);

if (!map.pixelBounds.containsPartialBounds(Bounds(sw, ne))) {
continue;
Expand All @@ -287,8 +295,8 @@ class _MarkerLayerState extends State<MarkerLayer> {
key: marker.key,
width: marker.width,
height: marker.height,
left: pos.x - width,
top: pos.y - height,
left: pos.x - leftPortion,
top: pos.y - topPortion,
child: markerWidget,
),
);
Expand Down