Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.1.0 Release & Keep Alive Functionality #1312

Merged
merged 6 commits into from
Jul 22, 2022
Merged

v2.1.0 Release & Keep Alive Functionality #1312

merged 6 commits into from
Jul 22, 2022

Conversation

JaffaKetchup
Copy link
Member

@JaffaKetchup JaffaKetchup commented Jul 19, 2022

Designed to complement #1293. Added a keepAlive option (defaults to false) to MapOptions. Mixed in AutomaticKeepAliveClientMixin with FlutterMapState, and made necessary changes. Set wantKeepAlive getter to return the value of the keepAlive option.

Also contains the updates needed for v2.1.0 release. Waiting on all PRs marked with '[v2.1.0]' before merging this, as the CHANGELOG will need to be updated for each of them.

@JaffaKetchup JaffaKetchup requested a review from ibrierley July 19, 2022 09:02
@JaffaKetchup JaffaKetchup marked this pull request as ready for review July 19, 2022 09:04
@JaffaKetchup JaffaKetchup changed the title Added Keep Alive Functionality v2.1.0 Release & Keep Alive Functionality Jul 20, 2022
@JaffaKetchup JaffaKetchup self-assigned this Jul 20, 2022
@JaffaKetchup JaffaKetchup marked this pull request as draft July 20, 2022 10:09
@JaffaKetchup JaffaKetchup marked this pull request as ready for review July 20, 2022 15:46
@JaffaKetchup JaffaKetchup marked this pull request as draft July 21, 2022 13:54
@JaffaKetchup
Copy link
Member Author

Waiting on #1315 to be merged if possible.

@ibrierley
Copy link
Contributor

What's the best way to test this one (I can't seem to recreate the map not being kept alive in a listview for example, but it maybe something I'm doing wrong...)

@JaffaKetchup
Copy link
Member Author

@ibrierley I just used the code over at #1288 (comment), and toggled the keepAlive option in MapOptions to see the difference. When disabled, scrolling back up to the map should reset it to its original location, otherwise it should 'remember' where it was.

Copy link
Contributor

@ibrierley ibrierley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests good for me, thanks for the work.

@JaffaKetchup JaffaKetchup marked this pull request as ready for review July 22, 2022 15:08
@JaffaKetchup JaffaKetchup merged commit e6a7794 into fleaflet:master Jul 22, 2022
@JaffaKetchup
Copy link
Member Author

Thanks, and no problem. I'll do a release in just a minute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants