-
-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fallback URLs (for #1203) #1348
Conversation
Thanks @TesteurManiak! I'll have a look at this for v3.1.0 :) |
Hi, @JaffaKetchup I've merged the latest changes from master on the branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the changes I suggested below.
Can you also bring this up to date with v3 if needs be? For example, I know the AssetTileProvider
was added back and this might cause problems.
@JaffaKetchup everything should be ok now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks.
Fix #1203
NetworkTileProvider
andNetworkNoRetryTileProvider
fromtile_provider_io.dart
&tile_provider_web.dart
to support afallbackUrl
RetryClient
by a simpleClient
class as I think it is not needed to enforce a retry client, we should simply be able to use anyClient
class we want (+ allows to useFMNetworkImageProvider
insidetile_provider_web.NetworkNoRetryTileProvider.getImage
)AssetTileProvider
which was missing for some unknown reasons and added support forfallbackUrl
by implementing a private class_FlutterMapAssetBundle
which will try to load an asset in the same way as the defaultPlatformAssetBundle
, but will also try to load a fallback asset if the first one wasn't found.FallbackUrlNetworkPage
&FallbackUrlOfflinePage
Changes have been tested on Android and Chrome, no regressions were found.